Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-abis/+/42652?usp=email )
Change subject: abis: add optional WebSDR E1 input driver ...................................................................... Patch Set 1: (8 comments) File include/osmocom/abis/websdr.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/039314e4_c092de89?usp=email : PS1, Line 60: #endif /* OSMO_ABIS_WEBSDR_H */ adding a line without newline at end of file File src/input/websdr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/94253633_5ff87dfe?usp=email : PS1, Line 88: if (!msg) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/75dfc40b_5f247532?usp=email : PS1, Line 145: switch(line->ops->cfg.ipa.role) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/f88497ba_cd20fdb1?usp=email : PS1, Line 405: struct e1inp_line* line = g_line_cb; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/6d813793_00340101?usp=email : PS1, Line 447: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/1feebefa_2953cd77?usp=email : PS1, Line 502: if (ret == 0) suspect code indent for conditional statements (16, 23) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/0a6242fa_0e02573c?usp=email : PS1, Line 503: goto discard_msg; Statements should start on a tabstop Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-abis/+/42652/comment/425614f1_0c33357b?usp=email : PS1, Line 601: int ws_ipa_push_raw_data(unsigned ts_nr, const char* data, unsigned sz) "foo* bar" should be "foo *bar" -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib804dc8eb67a91678603f54ea0beccd5c61e4a80 Gerrit-Change-Number: 42652 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 22 Apr 2026 20:48:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
