Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email )
Change subject: osmo_io: iofd_txqueue_dequeue(): fix double next->io_len decrement ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Patch LGTM, but I feat the test will trigger eventually non-deterministic results based on read/write internal buffers in the OS. ACK to making a patch release. BTW, it would make sense to move the code block " Fill up empty buffers in dequeued msghdr with buffers from the next msghdr" into a helper function, and actually optimize it to move multiple msgs from the same next msghdr in a tight loop instead of 1 by 1. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia96e25d11d8d683fa9dd0c56bdac257992edd782 Gerrit-Change-Number: 42638 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 20 Apr 2026 08:07:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
