fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/42600?usp=email )
Change subject: assignment_fsm: ipacc_chan_mode_supported(): log unsupported
chan_mode
......................................................................
assignment_fsm: ipacc_chan_mode_supported(): log unsupported chan_mode
Change-Id: I1718994e25ff1349618bdb4660afbe735c5c3977
Related: aa959d74f ("assignment_fsm: check ipaccess channel mode support")
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
jolly: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index 54a57aa..cae0425 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -442,7 +442,13 @@
return true; /* unknown channel mode */
}
- return (feat->val & flag) != 0;
+ if (feat->val & flag)
+ return true;
+
+ LOG_ASSIGNMENT(lchan->conn, LOGL_NOTICE,
+ "BTS does not support channel mode '%s'\n",
+ get_value_string(abis_nm_ipacc_chanm_desc, flag));
+ return false;
}
static bool lchan_type_compat_with_mode(const struct gsm_lchan *lchan,
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42600?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1718994e25ff1349618bdb4660afbe735c5c3977
Gerrit-Change-Number: 42600
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: jolly <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
