Attention is currently required from: fixeria. falconia has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email )
Change subject: firmware/se_k2xx: add board specific RF tables ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Patchset: PS2: > This is already implemented and working. Here's the firmware boot log for > K2xx: […] Done File src/target/firmware/board/se_k2xx/rf_tables.c: https://gerrit.osmocom.org/c/osmocom-bb/+/42604/comment/b62b2f2f_642c85bc?usp=email : PS2, Line 30: uint8_t apc_offset = 48; > Just to clarify: `APCOFF = 0x07F` is 127 in decimal, but you suggest 63. […] Your comment in the new patch iteration is fine. For the structure of APCOFF register, see TWL3025_SWRS021.pdf document, section 5.3.6.5 on page 71. The low 6 bits are the APC offset (the number we are after here, and the field after which the register was named), but bit 0x40 is another, mostly unrelated setting. That other bit setting (ramp slope selection) is not factored out per-target in OBB, but it does not need to be: the current setting of 1 is correct for all currently supported targets. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If90973ae6bf9af1cd15e2d80e0b99fe098b648bd Gerrit-Change-Number: 42604 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Sat, 11 Apr 2026 15:55:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
