Attention is currently required from: fixeria.

falconia has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/42605?usp=email )

Change subject: firmware/se_k2xx: add board specific AFC params
......................................................................


Patch Set 2:

(1 comment)

File src/target/firmware/board/se_k2xx/afcparams.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/42605/comment/d9688561_172d5d1d?usp=email
 :
PS2, Line 42: int16_t afc_initial_dac_value = -2957;
DAC center, min and max numbers in TI's afcparams table are written with a left 
shift of 3 bits! (More precisely, it is a fixed point format with 3 digits to 
the right of the binary point.) Therefore, based on your averages you should 
set `afc_initial_dac_value` to -369 or -370 instead.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42605?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iee2569c124dd0160f16457e0171cfd48d961045e
Gerrit-Change-Number: 42605
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: falconia <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Sat, 11 Apr 2026 00:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to