Attention is currently required from: fixeria.

jolly has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/42593?usp=email )

Change subject: handover_fsm: fix send_handover_performed() using wrong lchan
......................................................................


Patch Set 2:

(1 comment)

File src/osmo-bsc/handover_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/42593/comment/5cbe41c8_ee4151cc?usp=email
 :
PS2, Line 901:  struct gsm_lchan *lchan = ho->new_lchan;
What if new_lchan is NULL?

If I look at the caller of this function (handover_end()), I am not sure, if it 
is never NULL.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42593?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4111351dc38fc2dbe844c2bd07b3ecfaaadd864e
Gerrit-Change-Number: 42593
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: jolly <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 08 Apr 2026 10:33:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to