Attention is currently required from: canghaiwuhen, laforge, pespin. fixeria has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email )
Change subject: gprs_sm: gsm48_tx_gsm_act_pdp_acc(): fix QoS profile length ...................................................................... Patch Set 19: (5 comments) Patchset: PS3: > Please also adjust the commit message text to have a brief distinct subject > and more detailed descri […] Done Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/55ed692c_41b6b93f?usp=email : PS5, Line 7: Some older modules, such as the Air20X module, may crash during PDP attachment due to excessively long QoS response packets. > Missing first line with acceptable length. You are writing the whole > description in the first line. Done File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/f5f7e55e_2a8e5057?usp=email : PS5, Line 1339: } else { > All changes in this file are totally unrelated to those of QoS. […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/0ebb45b7_ab85a7ef?usp=email : PS5, Line 1340: /* [FIX] Known IMSI context. If the module initiates an Attach, it means it has restarted and lost its PDP state. > These lines are too long, split them. Done https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/e3dce2da_e6556276?usp=email : PS5, Line 1344: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi); > Line too long. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11c24b64f0e49cf80c825969dbf018b2948d855c Gerrit-Change-Number: 42050 Gerrit-PatchSet: 19 Gerrit-Owner: canghaiwuhen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: canghaiwuhen <[email protected]> Gerrit-Comment-Date: Mon, 06 Apr 2026 16:28:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
