pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email )
Change subject: stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP
......................................................................
stp: m3ua: Expect unsolicited ASPIA ACK after unblocking ASP
Since libosmo-sigtran.git Change-Id
If32902575e874d2acc9a5fc12509af42ed151739, osmo-stp will send an
unsolicited ASPIA ACK to the peer whenever the ASP becomes unblock, in
order to somehow give a chance to the peer to notice something changed
and for instance possibly attempt re-activation of the ASP.
Related: OS#6752
Change-Id: I4b70e576beae3c386d68f17a60d6f23d1a54293a
---
M stp/STP_Tests_M3UA.ttcn
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn
index ca7dead..ac9cc25 100644
--- a/stp/STP_Tests_M3UA.ttcn
+++ b/stp/STP_Tests_M3UA.ttcn
@@ -674,6 +674,9 @@
f_M3UA_exp(0, tr_M3UA_ERR('0000000D'O, rctx_sender));
f_vty_cs7_asp_cmd(g_m3ua_configs[0], "no block");
+ /* osmo-stp transmits an unsolicited ASPIA ACK to inform it went
locally unblocked,
+ * in order to give a chance to the peer to re-attempt re-activation. */
+ f_M3UA_exp(0, tr_M3UA_ASPIA_ACK(rctx_sender));
f_M3UA_asp_act(0, c_M3UA_TMT_override, rctx_sender, ntfy_after_act :=
c_M3UA_ST_I_AS_ACTIVE);
f_clear_m3ua();
@@ -694,6 +697,9 @@
f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG,
c_M3UA_ST_I_AS_INACTIVE, rctx_sender));
f_vty_cs7_asp_cmd(g_m3ua_configs[0], "no block");
+ /* osmo-stp transmits an unsolicited ASPIA ACK to inform it went
locally unblocked,
+ * in order to give a chance to the peer to re-attempt re-activation. */
+ f_M3UA_exp(0, tr_M3UA_ASPIA_ACK(rctx_sender));
f_M3UA_asp_act(0, c_M3UA_TMT_override, rctx_sender, ntfy_after_act :=
c_M3UA_ST_I_AS_ACTIVE);
f_clear_m3ua();
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42576?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4b70e576beae3c386d68f17a60d6f23d1a54293a
Gerrit-Change-Number: 42576
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
