pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42558?usp=email )

 (

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: xua_as_fsm: Remove FIXME regarding queueing of msgs during 
state PENDING
......................................................................

xua_as_fsm: Remove FIXME regarding queueing of msgs during state PENDING

Queueing of messags during T(r) (state PENDING) is already implemented,
see xua_as_fsm_pending() further below in the same file.

Change-Id: Ie572367493066039f7022250d94b815a4da5bd16
---
M src/xua_as_fsm.c
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c
index 6828989..568834e 100644
--- a/src/xua_as_fsm.c
+++ b/src/xua_as_fsm.c
@@ -585,8 +585,6 @@
                        osmo_fsm_inst_state_chg(fi, XUA_AS_S_PENDING, 0, 0);
                        /* Start T(r) */
                        osmo_timer_schedule(&xafp->recovery.t_r, 
MSEC_TO_S_US(recovery_msec));
-                       /* FIXME: Queue all signalling messages until
-                        * recovery or T(r) expiry */
                }
                break;
        case XUA_ASPAS_ASP_INACTIVE_IND:
@@ -596,8 +594,6 @@
                        osmo_fsm_inst_state_chg(fi, XUA_AS_S_PENDING, 0, 0);
                        /* Start T(r) */
                        osmo_timer_schedule(&xafp->recovery.t_r, 
MSEC_TO_S_US(recovery_msec));
-                       /* FIXME: Queue all signalling messages until
-                        * recovery or T(r) expiry */
                } else if (inact_ind_pars->asp_requires_notify) {
                        fill_notify_statchg_pars(fi, &npar);
                        tx_notify(inact_ind_pars->asp, &npar);

--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42558?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ie572367493066039f7022250d94b815a4da5bd16
Gerrit-Change-Number: 42558
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>

Reply via email to