Attention is currently required from: laforge, laforge.
daniel has posted comments on this change by daniel. (
https://gerrit.osmocom.org/c/python/pyosmocom/+/42556?usp=email )
Change subject: tlv: Allow control over comprehension bit in COMPR_TLV_IE
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> The function already supports a {tag, comprehension} input syntax for the
> 'tag' argument. […]
I looked at that, but the tag is a property of the (sub-)class and used in the
metaclass:
``` python
# TS 102 223 Section 8.35
class CApdu(COMPR_TLV_IE, tag=0xA2):
_construct = GreedyBytes
```
The metaclass (ComprTlvMeta) constructor __new__ assumes that tag is an int.
The constructor of the actual subclass (e.g. CApdu) does not do anything with a
tag variable - even if you passed it.
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/42556?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I9ca689b9b51152f3907ea470c7b42a0b12208459
Gerrit-Change-Number: 42556
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Tue, 31 Mar 2026 08:56:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
