fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/42523?usp=email )
Change subject: osmo-bts-trx: rx_rach_fn(): remove redundant fall-back
......................................................................
osmo-bts-trx: rx_rach_fn(): remove redundant fall-back
Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true,
given that no other synch. sequences are defined by 3GPP TS 45.002.
Even if this happens for whatever reason (e.g. a bug), assigning
`synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq`
is never read after the switch statement. The logging message is
not useful either, since we already print the synch. seq. above.
Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1
---
M src/osmo-bts-trx/sched_lchan_rach.c
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bts-trx/sched_lchan_rach.c
b/src/osmo-bts-trx/sched_lchan_rach.c
index c92dfe2..a4a01a9 100644
--- a/src/osmo-bts-trx/sched_lchan_rach.c
+++ b/src/osmo-bts-trx/sched_lchan_rach.c
@@ -186,12 +186,6 @@
case RACH_SYNCH_SEQ_TS0:
default:
- /* Fall-back to the default TS0 if needed */
- if (synch_seq != RACH_SYNCH_SEQ_TS0) {
- LOGL1SB(DL1P, LOGL_DEBUG, l1ts, bi, "Falling-back to
the default TS0\n");
- synch_seq = RACH_SYNCH_SEQ_TS0;
- }
-
rc = gsm0503_rach_decode_ber(&ra, bi->burst + RACH_EXT_TAIL_LEN
+ RACH_SYNCH_SEQ_LEN,
trx->bts->bsic, &n_errors,
&n_bits_total);
if (rc) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42523?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1
Gerrit-Change-Number: 42523
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
