Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520?usp=email )
Change subject: stp: STP_Tests_IPA: Introduce tests
TC_ipa_tcp_{cli,srv}_adm_shutdown
......................................................................
Patch Set 1:
(2 comments)
File stp/STP_Tests_IPA.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520/comment/07258a8d_ab3f657d?usp=email
:
PS1, Line 209: //if (not g_ipa_configs[i].is_server) {
Maybe add a comment explaining why the if is commented out?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520/comment/873dde39_f3b9a14b?usp=email
:
PS1, Line 230: f_listen_ipa
I am not strictly against abusing this function, but IMO a separate function
with a self-explaining name (e.g. `f_ensure_no_conn(idx, Tval)` or whatever you
like better) would be cleaner.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie30de6caa3e2b680aff9e50898e63f615b526500
Gerrit-Change-Number: 42520
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Sat, 28 Mar 2026 17:34:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
