fixeria has submitted this change. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42488?usp=email )
Change subject: pfcp_peer: tune Heartbeat Request/Response logging
......................................................................
pfcp_peer: tune Heartbeat Request/Response logging
Reduce verbosity of the Tx/Rx Heartbeat Req/Resp log messages from
LOG_INFO to LOG_DEBUG in preparation for periodic heartbeat support.
Without this change, periodic heartbeats would flood the logging.
Change-Id: I6435cdf64fd86fa5358d57ea4d56dcad8eb9e69e
---
M src/pfcp_peer.erl
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl
index a6f4b03..30b45bd 100644
--- a/src/pfcp_peer.erl
+++ b/src/pfcp_peer.erl
@@ -581,7 +581,7 @@
seq_nr = SeqNr,
loc_rts = LRTS} = S0) ->
ReqIEs = #{recovery_time_stamp => #recovery_time_stamp{time = LRTS}},
- ?LOG_INFO("Tx Heartbeat Request (SeqNr=~p): ~p", [SeqNr, ReqIEs]),
+ ?LOG_DEBUG("Tx Heartbeat Request (SeqNr=~p): ~p", [SeqNr, ReqIEs]),
case send_pdu({heartbeat_request, ReqIEs}, S0) of
{ok, S1} ->
s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_HEARTBEAT_REQ_TX),
@@ -603,7 +603,7 @@
ie = RspIEs},
{_FromIp, _FromPort},
#peer_state{heartbeat = HB} = S) ->
- ?LOG_INFO("Rx Heartbeat Response (SeqNr=~p): ~p", [SeqNr, RspIEs]),
+ ?LOG_DEBUG("Rx Heartbeat Response (SeqNr=~p): ~p", [SeqNr, RspIEs]),
s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_HEARTBEAT_RESP_RX),
case HB of
#heartbeat_state{from = From,
@@ -628,7 +628,7 @@
ie = ReqIEs},
{FromIp, FromPort},
#peer_state{loc_rts = LRTS} = S) ->
- ?LOG_INFO("Rx Heartbeat Request from ~p:~p: ~p", [FromIp, FromPort,
ReqIEs]),
+ ?LOG_DEBUG("Rx Heartbeat Request from ~p:~p: ~p", [FromIp, FromPort,
ReqIEs]),
s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_HEARTBEAT_REQ_RX),
s1gw_metrics:ctr_inc(?S1GW_CTR_PFCP_HEARTBEAT_RESP_TX),
RspIEs = #{recovery_time_stamp => #recovery_time_stamp{time = LRTS}},
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42488?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I6435cdf64fd86fa5358d57ea4d56dcad8eb9e69e
Gerrit-Change-Number: 42488
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
