Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42502?usp=email )
Change subject: rspro_server: use correct byte order in log message "Bankd IP/Port changed to <IP>:<Port> ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/server/rspro_server.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42502/comment/624eb505_db857699?usp=email : PS1, Line 328: bankd_ip = ntohl(inet_addr(ip_str)); I wonder why are we actually storing conn->client.bankd.ip as a host-order buffer... Maybe it makes sense to simply store it as network byte and use it that way everywhere? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I288ea70091d24fa95732f7035ab50100831be841 Gerrit-Change-Number: 42502 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Thu, 26 Mar 2026 09:28:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
