Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501?usp=email )

Change subject: pgw: Test v6 and v4v6 PDU session userplane
......................................................................


Patch Set 1:

(8 comments)

File library/GTPv2_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/c1fe81c1_0da2a25a?usp=email
 :
PS1, Line 391: ts_GTP2C_PdnAddrAlloc
`tr_GTP2C_PdnAddrAlloc` (receive template) - unrelated, to this patch though.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/9fe5db26_2c707b52?usp=email
 :
PS1, Line 398: ts_GTP2C_PdnAddrAlloc
`tr_GTP2C_PdnAddrAlloc` (receive template)


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/da7f693d_a712517d?usp=email
 :
PS1, Line 405: ts_GTP2C_PdnAddrAlloc
`tr_GTP2C_PdnAddrAlloc` (receive template)


File pgw/PGW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/b3bbe492_bfa63608?usp=email
 :
PS1, Line 703: valueof
`valueof()` is not needed here


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/a2c8f36e_dd229b42?usp=email
 :
PS1, Line 718: valueof
likewise here, `valueof()` is not needed


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/5170f7a0_690c2a67?usp=email
 :
PS1, Line 835: iPv6_Address
copy-pasted, should be `iPv4_IPv6`


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/bcb05e3b_c69a45fb?usp=email
 :
PS1, Line 837: g_ip4_addr
Do we want to log the assigned IPv4 address like we do above?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501/comment/58139b38_fa492494?usp=email
 :
PS1, Line 988:                redirect_output := true,
             :
unneeded ws changes



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42501?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idf009b9118db8117c547a1bb0f27afdfa3f03924
Gerrit-Change-Number: 42501
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 25 Mar 2026 19:17:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to