fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42469?usp=email )
Change subject: pySim/EF.SMSP: fix encoding of TP-Destination Address ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/42469/comment/222c58c7_c0eeb6d0?usp=email : PS1, Line 10: TS-Service Centre Address field. However, even though the encoding > TS 31.102 consistently and repeatedly calls it "TS-Service Centre Address" 3 x times it's TS-Service Centre Address, and 1 x time it's TP-Service Centre Address. Also, in our code the respective field is named `tp_sc_addr` - this is why I got suspicious. TP is Transport Protocol, TS is... I have no idea. Anyways, not a merge blocker. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I55c123c9e244e5a6e71a0348f5d476ef03e618e8 Gerrit-Change-Number: 42469 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2026 19:07:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
