Attention is currently required from: laforge, neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email )
Change subject: personalization: implement reading back values from a PES ...................................................................... Patch Set 13: Code-Review+2 (4 comments) Patchset: PS13: To me everything looks fine here. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40198/comment/defadd47_8d597171?usp=email : PS11, Line 292: if isinstance(val, bytes): > the values are coming from a ProfileElementSequence's decoded section, should > always be either a hex […] I think everything is fine here. (I now know that the code uses bytes and hexstrings for parameters.) https://gerrit.osmocom.org/c/pysim/+/40198/comment/4480cc7e_385b26a5?usp=email : PS11, Line 297: val = unrpad(val, c) > I got this code from elsewhere (or reversing code from elsewhere?) […] Ah ok. So "4141" => "AA" is indeed what you want. Then everything is fine. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40198/comment/79fa47ec_fb919824?usp=email : PS13, Line 410: acc_f = pe.files.get('ef-acc', None) Apparently we are doing nothing with acc_f but I can see that in the following patch acc_f is used. If you want to make it perfect you could move this line into the correct patch, but I think it is not necessary. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 Gerrit-Change-Number: 40198 Gerrit-PatchSet: 13 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2026 15:20:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: dexter <[email protected]>
