Attention is currently required from: pespin.

fixeria has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482?usp=email )

Change subject: 5gc: Introduce test TC_pdu_sess_est_pco_pcscf
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File 5gc/C5G_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482/comment/15645c1a_a4fdea42?usp=email
 :
PS1, Line 410: valueof
These `valueof` are not really needed here because `cs_ExtdPCO` expects the 
second argument to be a template. Not critical, but I would remove them. Same 
applies to `cr_ExtdPCO`.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic7b22ad647bcac944551ac1c29080f895ca72cf8
Gerrit-Change-Number: 42482
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 25 Mar 2026 14:05:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to