Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42493?usp=email )

Change subject: s1gw: f_ConnHdlr_pfcp_assoc_handler(): handle already-connected 
case
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File s1gw/S1GW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42493/comment/24f58fd8_d2459dab?usp=email
 :
PS1, Line 143:  vc_conn := 
f_ConnHdlr_spawn(refers(f_ConnHdlr_pfcp_assoc_handler),
I wonder why do you need to spawn a new ConnHdlr to do some non-session related 
stuff. Sounds like it would be better to do it from test_CT instead?



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42493?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id9d2ebb1ddb3d3896dd24e2a37e9d21335441d52
Gerrit-Change-Number: 42493
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 25 Mar 2026 10:22:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to