Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42489?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now. Change subject: pfcp_peer: add configurable heartbeat miss count + association reset ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/pfcp_peer.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42489/comment/e8e309b1_83686d5f?usp=email : PS1, Line 115: hb_missed :: non_neg_integer() unanswered would probably be a better naming. BTW I'd say usually this is implemented as actually a "retrans" variable counting downwards. This allows knowing immediatelly how many tries remain without needing to look at the process config. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8cb0fb23468aba4dead9865a90d893c78c6ae074 Gerrit-Change-Number: 42489 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2026 10:15:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
