Attention is currently required from: osmith.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42460?usp=email )

Change subject: 5gc: Introduce tests TC_ng_register_ping6(_256)
......................................................................


Patch Set 2:

(2 comments)

File 5gc/C5G_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42460/comment/c3a2863c_9391c4ac?usp=email
 :
PS2, Line 436: f_ping4
> shouldn't this be ping6?
The naming of the function is actually wrong, it just works fine here. I'll 
rename it when supporting IPv4v6 addresses as a next step.


File 5gc/ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42460/comment/4e9d4704_b219a237?usp=email
 :
PS2, Line 1327:                 //user_addr := 
g_pars.ue_pars.sess_pars.ipv6_interface_id;
> do you want to keep this commented out line?
thanks, fixed it will push with next version of the patch.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42460?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iedf3697265b91bdda85e8d32402345ea8d58dc9f
Gerrit-Change-Number: 42460
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: osmith <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Comment-Date: Mon, 23 Mar 2026 16:23:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <[email protected]>

Reply via email to