fixeria has submitted this change. (
https://gerrit.osmocom.org/c/pysim/+/42376?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted
one.
)Change subject: global_platform: fix s/GET/STORE/ DATA in docs
......................................................................
global_platform: fix s/GET/STORE/ DATA in docs
Both `do_store_data` and `store_data` have identical docstrings that
incorrectly describe the command as GET DATA. Should be "STORE DATA".
Take a chance to fix missing space between `v2.3` and `Section`.
Change-Id: I33fc80ab8ca50fadc38217b0005eec6169c8e34e
---
M pySim/global_platform/__init__.py
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/pySim/global_platform/__init__.py
b/pySim/global_platform/__init__.py
index 8ed645c..810387b 100644
--- a/pySim/global_platform/__init__.py
+++ b/pySim/global_platform/__init__.py
@@ -562,14 +562,14 @@
@cmd2.with_argparser(store_data_parser)
def do_store_data(self, opts):
- """Perform the GlobalPlatform GET DATA command in order to store
some card-specific data.
- See GlobalPlatform CardSpecification v2.3Section 11.11 for
details."""
+ """Perform the GlobalPlatform STORE DATA command in order to store
some card-specific data.
+ See GlobalPlatform CardSpecification v2.3 Section 11.11 for
details."""
response_permitted = opts.response == 'may_be_returned'
self.store_data(h2b(opts.DATA), opts.data_structure,
opts.encryption, response_permitted)
def store_data(self, data: bytes, structure:str = 'none',
encryption:str = 'none', response_permitted: bool = False) -> bytes:
- """Perform the GlobalPlatform GET DATA command in order to store
some card-specific data.
- See GlobalPlatform CardSpecification v2.3Section 11.11 for
details."""
+ """Perform the GlobalPlatform STORE DATA command in order to store
some card-specific data.
+ See GlobalPlatform CardSpecification v2.3 Section 11.11 for
details."""
max_cmd_len = self._cmd.lchan.scc.max_cmd_len
# Table 11-89 of GP Card Specification v2.3
remainder = data
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42376?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I33fc80ab8ca50fadc38217b0005eec6169c8e34e
Gerrit-Change-Number: 42376
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
