Attention is currently required from: pespin.

laforge has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-uecups/+/42456?usp=email )

Change subject: Implement logic to perform IPv6 SLAAC in GTPU tunnel
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File daemon/checksum.c:

https://gerrit.osmocom.org/c/osmo-uecups/+/42456/comment/5cd34436_dd6474f5?usp=email
 :
PS1, Line 1: /*
If we don't want to move this to some kind of shared (or even only
static?) library: It might make sense to at least note which git version
 of which file in which source git repot this was copied from so one can
 more easily determine + import any fixes in the source repo.


File daemon/icmpv6.c:

https://gerrit.osmocom.org/c/osmo-uecups/+/42456/comment/989470ed_157f36e2?usp=email
 :
PS1, Line 1: /* Minimal ICMPv6 code for generating router advertisements as 
required by
If we don't want to move this to some kind of shared (or even only static?) 
library: It might make sense to at least note which git version of which file 
in which source git repot this was copied from so one can more easily determine 
+ import any fixes in the source repo.



--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/42456?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I837a4d7ec7c134412ab4a2e09909670e81ecbeea
Gerrit-Change-Number: 42456
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 20 Mar 2026 20:26:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to