Attention is currently required from: fixeria, laforge, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email )
Change subject: transceiver: return -EINVAL for invalid SETSLOT ...................................................................... Patch Set 2: (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/5632473a_f7ab76da?usp=email : PS1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ > After looking at the follow up commit, I also understand now what > @[email protected] means. […] I see your point. However, this would change the original behavior. Before splitting the code, when an invalid timeslot was provided, ctrl_sock_handle_rx() would return 0 and exit the function, so no response was sent. If we keep returning 0 after the refactoring, the command would now be answered, which was not the case before. So this would slightly change the original logic. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53 Gerrit-Change-Number: 42421 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Wed, 18 Mar 2026 12:29:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: Timur Davydov <[email protected]>
