Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42429?usp=email )

Change subject: [REST] Implement eNB/MME selection by addr-port
......................................................................


Patch Set 1:

(1 comment)

File src/rest_server.erl:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42429/comment/5fcbbfe1_37f520cb?usp=email
 :
PS1, Line 275: %% parse address/port from a string like "192.168.1.1-36412"
> why are we using this format? why not usual ":" to separate IP and port? (and 
> "[ipv6]:port" for ipv6 […]
I don't remember why I choose `addr-port` over `addr:port`. Perhaps because `:` 
is already used for separating the selector and value in 
`#/components/parameters/MmeId`. Let's see if I can quickly rework it to use 
`:` instead, before it's implemented.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42429?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: If02c8de1e1b7214bba868eee35233a79d0704dc5
Gerrit-Change-Number: 42429
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 18 Mar 2026 12:03:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to