Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368?usp=email )
Change subject: doc/manuals: merge doc/osmo-s1gw-cli.md ...................................................................... Patch Set 5: (2 comments) File doc/manuals/chapters/cli.adoc: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368/comment/dcfbcd6c_6c1a1edf?usp=email : PS4, Line 34: > is so much verbosity useful? this all needs to be kept in sync with changes > to the program I see no problem here either. I do not expect the new command line arguments to be added often, and even if we have to, updating the user manual is not a big deal. File doc/manuals/chapters/rest.adoc: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368/comment/0ee8031a_ba4951c9?usp=email : PS4, Line 290: === Interactive CLI (`osmo-s1gw-cli`) > this was just added in the previous patch, not great for code review :\ I am just moving this block into a dedicated file that documents `osmo-s1gw-cli`. Not sure what's wrong here, but I've removed this section from previous patch to avoid confusion. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic2556f6add9c6a24f6da03f4388d7f86dde0c5dc Gerrit-Change-Number: 42368 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2026 15:54:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]>
