Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367?usp=email )
Change subject: doc/manuals: document the REST interface ...................................................................... Patch Set 4: (2 comments) File doc/manuals/chapters/rest.adoc: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367/comment/36352d7c_74bff73d?usp=email : PS4, Line 294: filtering : (`CMD | grep ...`), and output redirection (`CMD > FILE`). piping into grep or redirecting into a file are not features of this program, these are features of the shell that could be done with wget $RESTURL as well. I would remove that. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367/comment/14684598_d2bb7c26?usp=email : PS4, Line 299: Here it might also make sense to just refer to `osmo-s1gw-cli -h` instead of duplicating the help in the manual (and having to keep it updated in both places)? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8bc9183fff8f65db71554ee26369db9bdb61b78a Gerrit-Change-Number: 42367 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:26:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
