Attention is currently required from: fixeria, laforge.

pespin has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email )

Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1: 
> maybe the point was to zero-initialize some part of the truct?  AFter all, it 
> doesn't look like we'r […]
The man documentation states the struct is passed, so imho looks like a good 
thing to set flags field to 0.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849
Gerrit-Change-Number: 42406
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 16 Mar 2026 08:45:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to