fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email )


Change subject: mobile: gsm48_cc_tx_release_compl(): actually send the message
......................................................................

mobile: gsm48_cc_tx_release_compl(): actually send the message

The message buffer is allocated, filled in, and then leaked when
`trans_free(trans)` is called.  The RELEASE COMPLETE message is
never transmitted to the network.

Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77
---
M src/host/layer23/src/mobile/gsm48_cc.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/01/42401/1

diff --git a/src/host/layer23/src/mobile/gsm48_cc.c 
b/src/host/layer23/src/mobile/gsm48_cc.c
index 2a8823f..869f57a 100644
--- a/src/host/layer23/src/mobile/gsm48_cc.c
+++ b/src/host/layer23/src/mobile/gsm48_cc.c
@@ -1710,6 +1710,8 @@
        if (rel->fields & MNCC_F_SSVERSION)
                gsm48_encode_ssversion(nmsg, &rel->ssversion);

+       gsm48_cc_to_mm(nmsg, trans, GSM48_MMCC_DATA_REQ);
+
        /* release without sending MMCC_REL_REQ */
        new_cc_state(trans, GSM_CSTATE_NULL);
        trans->callref = 0;

--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77
Gerrit-Change-Number: 42401
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>

Reply via email to