osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email )
Change subject: Fix decoding of TCAP messages ...................................................................... Fix decoding of TCAP messages Recent versions of asn1c fail while decoding the DialoguePortion of a TCAP message - probably because Tag APPLICATION 11 is sent as constructed tag and the WS adaptation expects a primitive one. Not sure if this ever worked with an older asn1c version, maybe it ignored this discrepancy. The described behavior also happens with mouse07410/asn1c 2c06555 used in the next patch to regenerate the code. In any case the correct encoding of the DialoguePortion is as EXTERNAL. Support for proper EXTERNAL asn1c decoding is missing in all versions of asn1c except https://github.com/mouse07410/asn1c (See PR #3/#5) so use that when regenerating. Related: SYS#7486 Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65 --- M asn/tcap.asn 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve osmith: Verified diff --git a/asn/tcap.asn b/asn/tcap.asn index 9df2e5b..2b967cd 100644 --- a/asn/tcap.asn +++ b/asn/tcap.asn @@ -66,11 +66,11 @@ -- APDU, or by the TC-User in which case it could be either an ABRT APDU or data in some user-defined -- abstract syntax. ---DialoguePortion ::= [APPLICATION 11] EXPLICIT EXTERNAL +DialoguePortion ::= [APPLICATION 11] EXPLICIT EXTERNAL -- WS adaptation -DialoguePortion ::= [APPLICATION 11] IMPLICIT DialogueOC -DialogueOC ::= OCTET STRING +--DialoguePortion ::= [APPLICATION 11] IMPLICIT DialogueOC +--DialogueOC ::= OCTET STRING -- The dialogue portion carries the dialogue control PDUs as value of the external data type. -- The direct reference should be set to { ccitt recommendation q 773 as (1) dialogue-as (1) version (1) } -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65 Gerrit-Change-Number: 41021 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: daniel <[email protected]>
