laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40903?usp=email )

 (

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: sctp_proxy: fix non-existent fields in fetch_info/0
......................................................................

sctp_proxy: fix non-existent fields in fetch_info/0

The mme_addr and mme_port have been moved into the conn_cfg sub-map.

Change-Id: I386a0268d5e465cbd5ad7ee02ed768425e6ec17f
Fixes: 1221b6d ("sctp_{client,server}: accept arguments in form of a map")
---
M src/sctp_proxy.erl
1 file changed, 7 insertions(+), 4 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve
  Jenkins Builder: Verified




diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl
index e8460a4..badadcd 100644
--- a/src/sctp_proxy.erl
+++ b/src/sctp_proxy.erl
@@ -205,10 +205,13 @@

 %% Event handler for all states
 handle_event(State, {call, From}, fetch_info,
-             #{handler := Pid} = S0) ->
-    ERABs = s1ap_proxy:fetch_erab_list(Pid),
-    S1 = maps:with([enb_aid, mme_aid, mme_addr, mme_port], S0),
-    S2 = S1#{state => State, erab_list => ERABs},
+             #{handler := Pid, conn_cfg := ConnCfg} = S0) ->
+    ERABs = s1ap_proxy:fetch_erab_list(Pid), %% TODO: separate API
+    S1 = maps:with([enb_aid, mme_aid], S0),
+    S2 = S1#{state => State,
+             erab_list => ERABs,
+             mme_addr => maps:get(raddr, ConnCfg),
+             mme_port => maps:get(rport, ConnCfg)},
     Reply = proplists:from_map(S2),
     {keep_state_and_data, {reply, From, Reply}};


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40903?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I386a0268d5e465cbd5ad7ee02ed768425e6ec17f
Gerrit-Change-Number: 40903
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>

Reply via email to