lynxis lazus has submitted this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email )

Change subject: s2b: set correct instance values for Bearers
......................................................................

s2b: set correct instance values for Bearers

The instance value is explicitly defined in 3GPP TS 29.274
for a given F-TEID in the Bearer IE and is
coupled to the F-TEID type on a specific interface.

Change-Id: Ibce4a2e44a3bb0d7e1d86953a94929242d45a3dd
---
M src/epdg_gtpc_s2b.erl
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  pespin: Looks good to me, approved




diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl
index cf3e90d..2f588fa 100644
--- a/src/epdg_gtpc_s2b.erl
+++ b/src/epdg_gtpc_s2b.erl
@@ -531,7 +531,7 @@
                   },
                   #v2_eps_bearer_id{eps_bearer_id = Bearer#gtp_bearer.ebi},
                   #v2_fully_qualified_tunnel_endpoint_identifier{
-                    instance = Bearer#gtp_bearer.ebi,
+                    instance = 5, %% "S2b-U ePDG F-TEID", Table 7.2.1-2
                     interface_type = 31, %% "S2b-U ePDG GTP-U"
                     key = Bearer#gtp_bearer.local_data_tei,
                     ipv4 = conv:ip_to_bin(LocalAddrGtpu)
@@ -588,7 +588,7 @@
         },
         #v2_eps_bearer_id{eps_bearer_id = Bearer#gtp_bearer.ebi},
         #v2_fully_qualified_tunnel_endpoint_identifier{
-        instance = 0,
+        instance = 8, %% "S2b-U ePDG F-TEID", Table 7.2.4-2
         interface_type = 31, %% "S2b-U ePDG GTP-U"
         key = Bearer#gtp_bearer.local_data_tei,
         ipv4 = conv:ip_to_bin(LocalAddrGtpu)

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37899?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ibce4a2e44a3bb0d7e1d86953a94929242d45a3dd
Gerrit-Change-Number: 37899
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>

Reply via email to