Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email )
Change subject: Add templates for S1AP Handover procedure ...................................................................... Patch Set 1: (11 comments) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/9dd59a67_f7986e90?usp=email : PS1, Line 2293: procedureCode := S1AP_Constants.id_HandoverPreparation, > Are you sure this ID is correct? It may look confusing, but yes, it's correct. See 3GPP TS 36.413, section 8.4.1 "Handover Preparation". https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/1d9ab67d_fd76dedd?usp=email : PS1, Line 2337: procedureCode := S1AP_Constants.id_HandoverPreparation, > Are you sure this ID is correct? It may look confusing, but yes, it's correct. See 3GPP TS 36.413, section 8.4.1 "Handover Preparation". https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/e3709bce_b93e2c69?usp=email : PS1, Line 2370: } > (FYI, see in > https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40985/2/library/ranap/RANAP_Templates. > […] Optional IEs can be added later whenever they're needed. For testing the S1 HANDOVER procedures, it's enough to have mandatory IEs only. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/8ac1fa85_cdbfc78c?usp=email : PS1, Line 2374: ts_E_RABSubjecttoDataForwardingList(template (value) E_RABDataForwardingItem it) := { > IMHO it's better to have a template for E_RABSubjecttoDataForwardingItem, and > then simply do "{ ts_E […] `E-RABSubjecttoDataForwardingItem` does not exist in the ASN.1 definition, so it's not possible to define templates for a single list item. This is how it's defined: ``` E-RABSubjecttoDataForwardingList ::= E-RAB-IE-ContainerList { {E-RABDataForwardingItemIEs} } ``` Same applies to the `E_RABModifyListBearerModConf` templates above. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/e1e49616_bddf4eac?usp=email : PS1, Line 2423: successfulOutcome := { > Are you sure the HandoverCmd is a succesfulOutcome and not an InitialMessage? > […] Yes, because this PDU is sent in response to the `HANDOVER REQUIRED`. * `HANDOVER REQUIRED` - `initiatingMessage`, * `HANDOVER COMMAND` - `successfulOutcome`. See 3GPP TS 36.413, section 8.4.1 "Handover Preparation". https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/19585d4b_fe0aee06?usp=email : PS1, Line 2424: procedureCode := S1AP_Constants.id_HandoverPreparation, > Are you sure this ID is correct? See above (yes). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/20931929_64317d60?usp=email : PS1, Line 2450: } We definitely want `E-RABs to Release List` IE (optional) here. Not a merge blocker, can be added later in a separate patch. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/5d45d5b8_b6e6a4a7?usp=email : PS1, Line 2462: procedureCode := S1AP_Constants.id_HandoverPreparation, > same comments as per ts_S1AP_HandoverCmd apply here too. See above. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/40b75a58_5b55317b?usp=email : PS1, Line 2560: procedureCode := S1AP_Constants.id_HandoverResourceAllocation, > are you sure this ID is correct? Yes. See 3GPP TS 36.413, section 8.4.2 "Handover Resource Allocation". https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/a0577d5d_8cc96782?usp=email : PS1, Line 2638: *, I see no optional IEs between the `E-RABs To Be Setup List` and `Source to Target Transparent Container`, so a wildcard is not needed here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/e3051405_106db251?usp=email : PS1, Line 2732: }, { Likewise, would be nice to have optional `E-RABs Failed to Setup List` IE here. Not a merge blocker, can be added later in a separate patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8b8aee0665a4f6644287b802f5e941bd82128f6 Gerrit-Change-Number: 41008 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Sun, 07 Sep 2025 10:23:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
