Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email )
Change subject: gsm48_cc_tx_setup_set_transaction_id: split out ...................................................................... Patch Set 2: (2 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/41038/comment/d531a250_0f7cd311?usp=email : PS1, Line 845: TX Setup with assigned transaction. This is not allowed > I find this message a bit confusing, maybe say "transaction ID is already > assigned"? […] done in a separate patch https://gerrit.osmocom.org/c/osmo-msc/+/41038/comment/3cfe702f_04097fa2?usp=email : PS1, Line 847: mncc_release_ind(trans->net, trans, trans->callref, : GSM48_CAUSE_LOC_PRN_S_LU, : GSM48_CC_CAUSE_RESOURCE_UNAVAIL); : > Maybe keep this in `gsm48_cc_tx_setup()`? […] I've considered it, but `gsm48_cc_tx_setup_set_bearer_cap` which gets split out later also sends `mncc_release_ind` in some (not all!) error code paths. There we can't also keep `mncc_release_ind` in `gsm48_cc_tx_setup`, so for consistency I'll keep it in the split-out functions for now. This is probably something that can be improved in future patches. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I715f12d09570211a98b667c56960309bd326e8d8 Gerrit-Change-Number: 41038 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 05 Sep 2025 08:40:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
