Attention is currently required from: fixeria, neels, pespin.

osmith has posted comments on this change by osmith. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email )

Change subject: msc: CC SETUP MT speech: verify bearer capabilities
......................................................................


Patch Set 5:

(2 comments)

File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044/comment/0857e669_a1d5e0c9?usp=email
 :
PS4, Line 1137:                 
BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_CC_SETUP(cpars.transaction_id, *, 
cpars.called_party)));
> you may want to add explicit "*" param here to easily spot the differences.
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044/comment/118b384a_797671d7?usp=email
 :
PS4, Line 1142: valueof
> No need to use `valueof()` here because `bcap` is a template parameter: […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536
Gerrit-Change-Number: 41044
Gerrit-PatchSet: 5
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 05 Sep 2025 08:43:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to