Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email )
Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ...................................................................... Patch Set 3: Code-Review+1 (5 comments) File include/s1gw_metrics.hrl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/441e3f91_f37388dd?usp=email : PS1, Line 36: handover_rsp > Let's use `handover_req_ack` here. Done File src/s1ap_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/8edfd8cd_e0a90ea6?usp=email : PS1, Line 640: PATH SWITCH > These PDUs are not implemented yet, so let's keep the TODO comments for them. Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/fbd13d53_ffa37606?usp=email : PS1, Line 642: fetch {MME,eNB}-UE-S1AP-ID values (mandatory IEs) > this comment is not relevant here? Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/2038de9a_3b570a0d?usp=email : PS1, Line 1092: 'transportLayerAddress' = TLA_In, : > cosmetic: formatting issues Done https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/53d7b9f1_8d811d3f?usp=email : PS1, Line 1113: 'transportLayerAddress' = TLA_In, : > cosmetic: formatting issues Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08 Gerrit-Change-Number: 41006 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:48:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <[email protected]>
