Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email )
Change subject: Regenerate code with newer asn1c ...................................................................... Patch Set 3: Code-Review-1 (4 comments) File include/AARE-apdu.h: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/1d81131b_107f25c4?usp=email : PS3, Line 1: /* These header files are all in the wrong directory. They should be placed under include/osmocom/tcap/ File include/Makefile.am: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/d42b8a1d_49671a4b?usp=email : PS3, Line 1: osmo_asn1_tcap_HEADERS = \ Missing (see osmo-cbc.git/include/osmocom/sbcap/Makefile.am): version.h: version.h.tpl $(AM_V_GEN)$(MKDIR_P) $(dir $@) $(AM_V_GEN)sed \ -e "s/{{VERSION}}/$$(echo '@VERSION@' | cut -d. -f1-3)/g" \ -e "s/{{VERSION_MAJOR}}/$$(echo '@VERSION@' | cut -d. -f1)/g" \ -e "s/{{VERSION_MINOR}}/$$(echo '@VERSION@' | cut -d. -f2)/g" \ -e "s/{{VERSION_PATCH}}/$$(echo '@VERSION@' | cut -d. -f3)/g" \ $< > $@ EXTRA_DIST = \ version.h.tpl \ $(NULL) File src/Makefile.am: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/a3405fb2_a1c26735?usp=email : PS3, Line 9: libosmo_asn1_tcap_la_SOURCES = \ IMHO this file should be doing stuff like osmo-cbc/src/sbcap/Makefile.am. File src/constr_CHOICE_print.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/7acef7f0_2fd6631a?usp=email : PS3, Line 1: /* I would really like/suggest to keep the generated C files in a separate directory, like done in osmo-cbc: osmo-cbc/src/sbcap/gen/ and osmo-cbc/src/sbcap/skel. This way it's far easier to spot where all the automatic churn is, vs extra functionalities we may want to add (function helpers, etc). -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec Gerrit-Change-Number: 41022 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: daniel <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Comment-Date: Thu, 04 Sep 2025 09:37:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
