Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40994?usp=email )
Change subject: s1ap_proxy: remove eNB-ID from erab_uid() ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Did you think about making eNB-UE-S1AP-ID optional when doing the lookup? > This way you get a more ro […] This will make the E-RAB lookup more complicated for... what kind of robustness? When doing the lookup with partial knowledge of the key (`erab_uid()`), you can no longer use `dict:find` or `dict:get`, you'll have to convert the dictionary to a list and recursively check each item. This is significantly slower. The only scenario I could think of is the `PATCH SWITCH` procedure, when it's the eNB establishing E-RAB (not the MME as usual). In that case the `PATH SWITCH REQUEST` contains only the `eNB-UE-S1AP-ID` alone. We do not implement this procedure yet, and implementing it would require quite a lot of additional changes. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40994?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7277d19080795600252306dbfa0c733f996e026e Gerrit-Change-Number: 40994 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 03 Sep 2025 13:43:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
