Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email )
Change subject: S1GW tests: Add test cases for S1 handover procedure ...................................................................... Patch Set 1: (4 comments) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/c3fc6ee7_62dc090f?usp=email : PS1, Line 71: template TargetID const c_TargetID https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/a79021dc_0e3c00be?usp=email : PS1, Line 76: /* PLMNidentity */ '62F210'O, you know you can assign by field name instead of commenting all of them? eg. pLMNidentity := '62F210'O https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/8a29cf9e_c032ba42?usp=email : PS1, Line 1072: function f_ConnHdlr_tx_handover_req(in ERabList erabs, either add in to all params or to none. (I vote for the later :P) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/89eb3014_64026f1d?usp=email : PS1, Line 1090: items[i] := ts_E_RABToBeSetupListHOReq(item)[0]; see the problem I mentioned in the previous commit? You end up doing weird stuff with [0] because you don't have a template for 1 item imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 Gerrit-Change-Number: 41009 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Wed, 03 Sep 2025 12:48:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
