Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email )
Change subject: iu_rnc: Split iu_rnc_register API into 2 steps ...................................................................... Patch Set 1: (2 comments) File src/sgsn/gprs_ranap.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40973/comment/71031275_b6739d95?usp=email : PS1, Line 377: > empty newline. Done File src/sgsn/iu_rnc.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40973/comment/3c9f52f6_dc34496a?usp=email : PS1, Line 80: if (rnc) { > (I don't know SCCP very well). […] Yes good point, I didn't think about that scenario with hnbgw. I'll need to take that into account when improving the existing code, since that's something different from other programs eg. osmo-msc. In any case afaiu I'm not really changing any existing logic in this commit. But I agree the existing logic may be flawed. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3761cc539c63a7ed680b04bb8136a43d397c10aa Gerrit-Change-Number: 40973 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Fri, 29 Aug 2025 12:46:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]>
