Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/40956?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Split most of iu_client.{c,h} into sccp.{c,h} and iu_rnc.{c,h}
......................................................................
Split most of iu_client.{c,h} into sccp.{c,h} and iu_rnc.{c,h}
* iu_rnc is easily spotted as an object class in the data domain which
can be put into its own file, handling its specific logic and data.
* SCCP code can also be moved into own specific file, which eases
self-containment of the layer logic and data.
* As a result, lots of RANAP Rx/Tx code in iu_client.{c,h} can also be
moved to the already existing gprs_ranap.{c,h}.
All these changes improve a lot readibility of code and makes it a lot
easier to improve/extend the different layers/objects in future patches.
Change-Id: I4c792ae665720460b5a954b5c7cbfe5acbc37473
---
M include/osmocom/sgsn/Makefile.am
M include/osmocom/sgsn/gprs_ranap.h
M include/osmocom/sgsn/iu_client.h
A include/osmocom/sgsn/iu_rnc.h
A include/osmocom/sgsn/sccp.h
M include/osmocom/sgsn/sgsn.h
M src/sgsn/Makefile.am
M src/sgsn/gprs_gmm_attach.c
M src/sgsn/gprs_ranap.c
M src/sgsn/iu_client.c
A src/sgsn/iu_rnc.c
A src/sgsn/sccp.c
M src/sgsn/sgsn.c
M src/sgsn/sgsn_main.c
M tests/gprs_routing_area/Makefile.am
M tests/sgsn/Makefile.am
16 files changed, 1,301 insertions(+), 1,054 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/56/40956/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40956?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4c792ae665720460b5a954b5c7cbfe5acbc37473
Gerrit-Change-Number: 40956
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <[email protected]>
