Attention is currently required from: pespin. neels has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40631?usp=email )
Change subject: ran_peer: Avoid paging attempt if not ready ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/c/osmo-msc/+/40631/comment/d99cccfb_14cf37a5?usp=email : PS3, Line 686: if (!rp->fi || rp->fi->state != RAN_PEER_ST_READY) have you noticed that osmo-msc generally does not need to check "if (!obj->fi)" because the priv object is the talloc child of the fi. Please only check the fi->state, because if rp exists, then rp->fi exists. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40631?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia858291f4454e4caf293e1aaf60ea04d2d4a64e9 Gerrit-Change-Number: 40631 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 14 Jul 2025 13:30:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
