Hi all,
WRT http://jira.codehaus.org/browse/GEOT-3726, I think I know the
motivation not to do
new AttributeImpl(value,descriptor, id == null? null : ff.gmlObjectId(id));
instead of new AttributeImpl(value,descriptor, ff.gmlObjectId(id));
as it's now, and it might be that we wanted factories to be logic-less?
Yet breaking the interface contract is not good.
If no objections I'll commit the above fix to build a no-id attribute
if null has been passed as the id argument.
But what should be done in the longer term, if enforcing logic-less
factories is so vital, is to extend the FeatureFactory interface with
overloaded versions of the create***Attribute methods, like in:
Attribute createAttribute(Object value, AttributeDescriptor descriptor);
Attribute createAttribute(Object value, AttributeDescriptor
descriptor, String id);
So that the former builds a null id attribute, and the later one with
id, and the client code is in charge of respecting the contract as it
should be?
Opinions?
Cheers,
Gabriel
2011/7/15 Gabriel Roldán (JIRA) <[email protected]>:
> AbstractFeatureFactoryImpl forces attribute id not to be null (and fails
> otherwise) even though the interface contract states id can be null
> --------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GEOT-3726
> URL: https://jira.codehaus.org/browse/GEOT-3726
> Project: GeoTools
> Issue Type: Bug
> Reporter: Gabriel Roldán
> Assignee: Gabriel Roldán
>
>
> The contract for FeatureFactory.createAttribute, createGeometryAttribute, and
> createComplexAttribute says the id argument can be null, yet
> AbstractFeatureFactoryImpl produces a NPE if given a null id as argument as
> it calls FilterFactory.gmlObjectId(id) without checking.
>
> Surprisingly there seems to be not a single call to any of these methods in
> the code base.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ------------------------------------------------------------------------------
> AppSumo Presents a FREE Video for the SourceForge Community by Eric
> Ries, the creator of the Lean Startup Methodology on "Lean Startup
> Secrets Revealed." This video shows you how to validate your ideas,
> optimize your ideas and identify your business strategy.
> http://p.sf.net/sfu/appsumosfdev2dev
> _______________________________________________
> Geotools-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.
------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric
Ries, the creator of the Lean Startup Methodology on "Lean Startup
Secrets Revealed." This video shows you how to validate your ideas,
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
