What about using an additional catch block, see below
Quoting Andrea Aime <[email protected]>:
> Hi,
> today I was looking into the JDBC data store due to some connection
> leaks reported in a very busy production server on too small for the
> job hardware and noticed patterns like this in connection handling:
>
> try {
> // this allows PostGIS to page the results and respect the
> fetch size
> if(getState().getTransaction() == Transaction.AUTO_COMMIT) {
> cx.setAutoCommit(false);
> }
>
> SQLDialect dialect = getDataStore().getSQLDialect();
> if ( dialect instanceof PreparedStatementSQLDialect ) {
> PreparedStatement ps =
> getDataStore().selectSQLPS(querySchema, preQuery, cx);
> reader = new JDBCFeatureReader( ps, cx, this,
> querySchema, query.getHints() );
> } else {
> //build up a statement for the content
> String sql = getDataStore().selectSQL(querySchema, preQuery);
> getDataStore().getLogger().fine(sql);
>
> reader = new JDBCFeatureReader( sql, cx, this,
> querySchema, query.getHints() );
> }
> } catch (Exception e) {
> // close the connection
> getDataStore().closeSafe(cx);
> // safely rethrow
> throw (IOException) new IOException().initCause(e);
> }
} catch (Throwable t) {
// close the connection if possible
if (cx!=null && getDataStore()!=null)
getDataStore().closeSafe(cx);
// rethrow
throw t;
}
>
> Uh, in case of OOM (or any other kind of Error) inside the try/catch
> block the connection would
> not be closed properly.
> I want to change those bits to catch Throwable instead.
>
> Opinions?
>
> Cheers
> Andrea
>
> --
> -------------------------------------------------------
> Ing. Andrea Aime
> GeoSolutions S.A.S.
> Tech lead
>
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
>
> phone: +39 0584 962313
> fax: +39 0584 962313
>
> http://www.geo-solutions.it
> http://geo-solutions.blogspot.com/
> http://www.youtube.com/user/GeoSolutionsIT
> http://www.linkedin.com/in/andreaaime
> http://twitter.com/geowolf
>
> -------------------------------------------------------
>
> ------------------------------------------------------------------------------
> Achieve unprecedented app performance and reliability
> What every C/C++ and Fortran developer should know.
> Learn how Intel has extended the reach of its next-generation tools
> to help boost performance applications - inlcuding clusters.
> http://p.sf.net/sfu/intel-dev2devmay
> _______________________________________________
> Geotools-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.
------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
