On 26/04/2010, at 7:11 PM, Andrea Aime wrote: > This hits another thing I've been hating quite a bit working on GSS, > having to either sprinkle generics all around turning the code into > an unreadable soup or bear up with Eclipse > complaints about the code not having the generics.
I have been adding some supress warnings annotations to my code; to indicate I am explicitly telling generics to go take a hike. It was the though of adding this to the geotools example code that got me motivated :-( > Humm... maybe SimpleFeatureCollection could return a SimpleFeatureIterator > too? I actually tried doing that for my first cut; and had to rollback and take things a step at a time. It is very possible; indeed we could proceed on the branch and perform this change if you think it was important? The branch as committed covers the needs of the GeoTools example code; we can take it further and cover: - SimpleFeatureIterator - SimpleFeatureWriter / SimpleFeatureReader > As stated before I like the direction this is going, just worried > a bit about the timing and the fact this would make porting patches > over from 2.6.x to trunk (or vice versa) harder for a few months > (until we release 2.7.0) So is that worry enough for a +0? Or could you make a good suggestion with respect to timing? Applying now: - I would like to test this direction with example code and issue a few milestones for feedback on the idea. I also hate the idea of making patches harder to apply. - If it helps andrea most of the code I modified is in abstract base classes; most of the implementation code is unaffected. As an example a ContentFeatureCollection is returned; the fact that ContentFeatureCollection now implements SimpleFeatureCollection is not really noticed when implementing. Applying later: - I will be unable to look at this until next weekend :-) - The "patch" is located on a branch we hopefully easies the cost of applying it (or updating the branch?). - I am not interested in keeping the branch going for the next couple of months; it would be easier to do the work again I suspect. Jody ------------------------------------------------------------------------------ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
