>> I have created a StyleFactoryImpl2 for you (on trunk); and started in >> on the implementation. If we can sort out everything on this class we >> will have little danger of breaking others. > > OK! > >> You will find I have cleaned up some of the classes that were >> providing difficulty; and implemented a few missing ones. > > OK, but we still have those two pending issues: > - Which Stroke to use when instantiating a (e.g.Line)SymbolizerImpl? Should > we convert from opengis to geotools?
That is what I have been doing; in each case I have made a "copy constructor": new StrokeImpl( org.opengis.style.Stroke ). Then I do an instanceof check on the stroke; if it is a StrokeImpl I use it directly; if not I use the copy constructor. I am not totally happy with this result; but it is something we can accomplish right now. > - In this Impl, should we change the member String geometryName to a > PropertyName? In that case, in StyleFactoryImpl2.lineSymbolier() we would > check the Expression geometry parameter to see if it is indeed a > PropertyName? I need to check what the StyleFactory says; I think it is still using a String? Making an API change is something we will need to do carefully as a team. Jody ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
