Hello again,

Thanks very much for your message. So you're right; testing again, I'm now 
consistently seeing the general form you described:

> ... WHERE (a in (v1, v2, v3) AND a IS NOT NULL)

Perhaps when I was still seeing the big chains of OR'd conditions I was looking 
at some old logs by accident, or still had an instance of 2.11 hanging around 
that I'd failed to shut down... unless layers imported from older versions of 
Geoserver could somehow cause the behavior to revert? Anyhow, I know to look 
out for it, so I can re-import affected layers as necessary if that's the case.

To follow up on the new-and-improved implementation under 2.16.x, setting a 
queried column to not be null under 2.11.2 caused the AND <some_column> IS NOT 
NULL to be omitted from the chain of ORs. Under 2.16.1 the AND <some_column> IS 
NOT NULL part seems to appear no matter what. On my particular stack, this 
doesn't seem to have a performance impact, but I didn't find any discussion 
about GEOT-6273 on any of the lists (devel/builds/users) as to whether this was 
intended or not. So again it's not a problem for me, but I figured I would 
check that's expected behavior in case the extra condition might affect anyone 
else.

- Patrick O'Toole
_______________________________________________
Geoserver-users mailing list

Please make sure you read the following two resources before posting to this 
list:
- Earning your support instead of buying it, but Ian Turton: 
http://www.ianturton.com/talks/foss4g.html#/
- The GeoServer user list posting guidelines: 
http://geoserver.org/comm/userlist-guidelines.html

If you want to request a feature or an improvement, also see this: 
https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer


Geoserver-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-users

Reply via email to