Walter and Andrea, a quick inspection of the stack at the moment this test is processing the external graphic suggests that this is the missing fix: https://github.com/geoserver/geoserver/pull/910 https://github.com/koordo/geoserver/commit/b67d1f78842e9f7b5e2b1f0e1b01318aba198a2f https://osgeo-org.atlassian.net/browse/GEOS-6870
The Jira issue is mislabelled. This fix has not been applied to 2.6.x or 2.7.x but is present on 2.8.x and master. You can see this with: git diff 2.7.x master -- ./main/src/main/java/org/geoserver/config/GeoServerDataDirectory.java Water, you can test this fix with 2.7.2 in your local working directory by "cherry-picking" and building on Windows with: git checkout 2.7.2 git cherry-pick b67d1f78842e9f7b5e2b1f0e1b01318aba198a2f mvn clean install Kind regards, Ben. P.S. Build failures should be on the geoserver-devel list, but we welcome on any list users keen enough to build GeoServer from source . :-) On 04/10/15 13:11, Ben Caradoc-Davies wrote: > Walter, > > apologies for the inconvenience. You are going everything right. The > detached head message is caused by the fact that you have checked out a > tag not a branch. This is fine, just a little confusing. To see all > branches: > > git branch -a > > To create a local branch 2.7.x tracking a remote branch origin/2.7.x and > check it out (assuming your remote is called origin (the default)): > > git checkout -b 2.7.x origin/2.7.x > > I do not expect that this will fix your problem. Now on to the failure: > > The error message looks like a problem validating file paths on Windows. > We introduced some stricter checks on these. As Andrea noted, no core > developers build on Windows, and his work to fix the build on Windows > has been on master and 2.8.x. > > To see if this failure has been fixed by Andrea's recent efforts to get > a Windows automated build working, please try building master: > > git checkout master > > And then in the src directory: > > mvn clean install > > If this works, there is likely a fix that could be backported to 2.7.x. > If it fails as before, there may be problem specific to your system. > Either way, we are interested in fixing it, as it may affect production > 2.7.x systems deployed on Windows. > > Please also send us the output of: > > mvn -version > > so we can see if there is anything unusual about your platform. > > Kind regards, > Ben. > > > On 03/10/15 23:41, Walter Stovall wrote: >> Following directions at >> http://docs.geoserver.org/latest/en/developer/quickstart/index.html >> >> I checked out and built the master branch successfully. But the maven build >> of 2.7.2 fails. I'm working on a Windows 7 client and have the latest >> git/maven installed. >> >> This is my first use of git/maven. I could not see existing branches as the >> quickstart indicates. So maybe my reference to "2.7.2" is not valid. But >> git seems to accept that. >> >> These are the steps I use to get/build at a windows cmd prompt: >> ------------------------------------------------------------------------------------------------------- >> C:\byers\git> >> C:\byers\git>git clone git://github.com/geoserver/geoserver.git >> geoserver2.7.2 >> Cloning into 'geoserver2.7.2'... >> remote: Counting objects: 162310, done. >> remote: Total 162310 (delta 0), reused 0 (delta 0), pack-reused 162310 >> Receiving objects: 100% (162310/162310), 125.08 MiB | 1.83 MiB/s, done. >> Resolving deltas: 100% (69685/69685), done. >> Checking connectivity... done. >> Checking out files: 100% (12388/12388), done. >> >> C:\byers\git>cd geoserver2.7.2 >> >> C:\byers\git\geoserver2.7.2>git checkout 2.7.2 >> Note: checking out '2.7.2'. >> >> You are in 'detached HEAD' state. You can look around, make experimental >> changes and commit them, and you can discard any commits you make in this >> state without impacting any branches by performing another checkout. >> >> If you want to create a new branch to retain commits you create, you may >> do so (now or later) by using -b with the checkout command again. Example: >> >> git checkout -b <new-branch-name> >> >> HEAD is now at 59ac4f6... updating version numbers and release notes for >> 2.7.2 >> >> C:\byers\git\geoserver2.7.2>cd src >> >> C:\byers\git\geoserver2.7.2\src>mvn clean install >> >> Maven kicks off the build including downloads and compiles and tests as it >> goes. >> >> Watching the console I see this during the build, other tests continue >> afterwards: >> Running org.geoserver.catalog.ResourcePoolTest >> Tests run: 11, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.647 sec >> <<< F >> AILURE! >> testSEStyleWithRelativePathProtocol(org.geoserver.catalog.ResourcePoolTest) >> Tim >> e elapsed: 5130 sec <<< ERROR! >> java.lang.IllegalArgumentException: Contains invalid >> images\rockFillSymbol.png p >> ath: /styles/ >> at org.geoserver.platform.resource.Paths.toPath(Paths.java:171) >> at org.geoserver.platform.resource.Paths.path(Paths.java:114) >> at org.geoserver.platform.resource.Paths.valid(Paths.java:194) >> at >> org.geoserver.platform.resource.FileSystemResourceStore.get(FileSyste >> mResourceStore.java:107) >> at >> org.geoserver.platform.GeoServerResourceLoader.get(GeoServerResourceL >> oader.java:173) >> at >> org.geoserver.config.GeoServerDataDirectory.get(GeoServerDataDirector >> y.java:113) >> at >> org.geoserver.config.GeoServerDataDirectory.urlToResource(GeoServerDa >> taDirectory.java:1413) >> at >> org.geoserver.config.GeoServerDataDirectory$1.locateResource(GeoServe >> rDataDirectory.java:1238) >> at >> org.geotools.styling.SLDParser.parseExternalGraphic(SLDParser.java:18 >> 30) >> at org.geotools.styling.SLDParser.parseGraphic(SLDParser.java:1673) >> at org.geotools.styling.SLDParser.parseFill(SLDParser.java:2033) >> at >> org.geotools.styling.SLDParser.parsePolygonSymbolizer(SLDParser.java: >> 1129) >> at org.geotools.styling.SLDParser.parseRule(SLDParser.java:946) >> at >> org.geotools.styling.SLDParser.parseFeatureTypeStyle(SLDParser.java:8 >> 52) >> at org.geotools.styling.SLDParser.parseStyle(SLDParser.java:808) >> at >> org.geotools.styling.SLDParser.parseNamedLayer(SLDParser.java:677) >> at >> org.geotools.styling.SLDParser.parseDescriptor(SLDParser.java:469) >> at org.geotools.styling.SLDParser.parseSLD(SLDParser.java:431) >> at org.geoserver.catalog.SLDHandler.parse10(SLDHandler.java:116) >> at org.geoserver.catalog.SLDHandler.parse(SLDHandler.java:108) >> at >> org.geoserver.config.GeoServerDataDirectory.parsedStyle(GeoServerData >> Directory.java:1257) >> at >> org.geoserver.catalog.ResourcePool.getStyle(ResourcePool.java:1746) >> at >> org.geoserver.catalog.impl.StyleInfoImpl.getStyle(StyleInfoImpl.java: >> 102) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. >> java:57) >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces >> sorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:606) >> at >> org.geoserver.catalog.impl.ModificationProxy.invoke(ModificationProxy >> .java:146) >> at com.sun.proxy.$Proxy13.getStyle(Unknown Source) >> at >> org.geoserver.catalog.ResourcePoolTest.testSEStyleWithRelativePathPro >> tocol(ResourcePoolTest.java:309) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. >> java:57) >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces >> sorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:606) >> at >> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Framework >> Method.java:47) >> at >> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCal >> lable.java:12) >> at >> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMe >> thod.java:44) >> at >> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMet >> hod.java:17) >> at >> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores. >> java:26) >> at >> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.ja >> va:27) >> at org.junit.rules.RunRules.evaluate(RunRules.java:20) >> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) >> at >> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRun >> ner.java:70) >> at >> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRun >> ner.java:50) >> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) >> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) >> at >> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) >> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) >> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) >> at >> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores. >> java:26) >> at >> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.ja >> va:27) >> at org.junit.runners.ParentRunner.run(ParentRunner.java:309) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provide >> r.java:252) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4 >> Provider.java:141) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider >> .java:112) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl. >> java:57) >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces >> sorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:606) >> at >> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray( >> ReflectionUtils.java:189) >> at >> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke >> (ProviderFactory.java:165) >> at >> org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(Provi >> derFactory.java:85) >> at >> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(Fork >> edBooter.java:115) >> at >> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java: >> 75) >> >> Then I get the output below: >> [INFO] >> ------------------------------------------------------------------------ >> [INFO] Reactor Summary: >> [INFO] >> [INFO] GeoServer .......................................... SUCCESS [ 1.634 >> s] >> [INFO] Core Platform Module ............................... SUCCESS [ 12.405 >> s] >> [INFO] Open Web Service Module ............................ SUCCESS [ 7.177 >> s] >> [INFO] Main Module ........................................ FAILURE [02:40 >> min] >> [INFO] GeoServer Security Modules ......................... SKIPPED >> [INFO] GeoServer JDBC Security Module ..................... SKIPPED >> [INFO] GeoServer LDAP Security Module ..................... SKIPPED >> ... >> >> Does anybody see where I'm going wrong? >> >> Assuming I'm doing the right things, what would I do to fix this problem? >> Try importing just what I have at this point into eclipse and debug there to >> make the test succeed? Then continue the maven build? >> >> Thank you - Walter >> >> >> >> ------------------------------------------------------------------------------ >> >> >> >> _______________________________________________ >> Geoserver-users mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geoserver-users >> > -- Ben Caradoc-Davies <[email protected]> Director Transient Software Limited <http://transient.nz/> New Zealand ------------------------------------------------------------------------------ _______________________________________________ Geoserver-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-users
