On Do, 13 Apr 21:55:29 +0200
Miroslav Rovis <miro.ro...@croatiafidelis.hr> wrote:
ERRATA: I wrote...
On 170413-21:19+0200, Miroslav Rovis wrote:
...
[... I wrote]:
Only ERRATA may follow in the topic, as far as I am concerned.
But I forgot floyd has got a "patch to keep the window position while
resizing the font" and offered it:
https://marc.info/?l=gentoo-user&m=149205691530349&w=2
And I, in my reply, accepted to try and apply it.
So, it depends on him if this topic is over or not.
It's very related, so probably best not to do any new subject for it.
Hi Miroslav,
back from some computer-free holidays, I haven’t forgotten that I owe
you a patch. Study my attached approach and if you like, apply the patch
at your own risk (it should be clean applicable to the currently latest
upstream commit [1]).
If you have any questions or ideas, get back to me. But keep in mind,
I’m neither a developer nor a GUI programmer guru.
It has some limits and/or doesn’t resolve certain issues:
- the patch assumes ‘NorthWest’ as the reference point for the window
gravity.
- if terminal background is colourised via escape sequences (as Andrew
mentioned in [2]), you may notice that a borderless window colourise
only full cells (of rows/columns), not the gap between a terminal
cell end and the window edge. Framed windows seems not to be
affected by this behaviour.
- window edges flutters/flickers while resizing fonts (independently
from step-size and also when using escape sequences for resizing)
- toggling a window between normal -> fullscreen/maximised state ->
and back, you may notice that the window size has changed. I don’t
know the reason for this issue (which occurs independently from the
urxvt-font-size extension and my patch).
- different window manager (WM) probably produces different
behaviours. Think about a WM that try to imitate a tiling window
manager by automatic resizing/positioning within a snapping area
near the desktop edges.
- patch is tested to my moderate needs but not fully with all kinds of
fonts, WMs, multi monitor environment, etc.
- ...
The patch is too unimportant to solve some/all of the above issues
and/or bloating up the urxvt extension script. And additionally,
rxvt-unicode won’t and doesn’t expose all Xlib functions (such as
XGetWindowAttributes) in urxvtperl, the embedded perl interpreter. So it
will be tricky sometimes, to solve a specific behaviour.
My used and tested urxvt-font-size related Xresource settings:
URxvt.font-size.keepwin: true
URxvt.font-size.step: 4
URxvt.keysym.C-0xffad: font-size:decrease
URxvt.keysym.C-0xffab: font-size:increase
URxvt.keysym.C-0xffb0: font-size:reset
Since I use the default keysyms for font-size:{decrease,increase,reset}
in Vim, I changed those defaults to C-KP_Substract (C-0xffad), C-KP_Add
(C-0xffab), C-KP_0 (C-0xffb0) like in Firefox and others.
References:
[1]
<https://github.com/majutsushi/urxvt-font-size/commit/0cc2624489fb60fcebf85d5c4dd62f425196c5b0>
[2]
<https://archives.gentoo.org/gentoo-user/message/a4d58e993934aa4a273998eda030d115>
--
Regards,
floyd
diff --git a/font-size b/font-size
index c16924c..8d3417e 100755
--- a/font-size
+++ b/font-size
@@ -105,6 +105,14 @@ size change sequence would be for example 8->12->16->20 instead of
available in specific sizes, though, and odd sizes are often not
available, resulting in an effective step size of 2 instead of 1
in that case.
+
+
+Controls whether or not to try to keep the window position/size while resizing
+the font size (assumes ‘NorthWest’ as reference point for the window gravity):
+
+ URxvt.font-size.keepwin: true
+
+Defaults to false if resource is omitted or cannot be treated as a boolean.
=cut
use strict;
@@ -122,6 +130,12 @@ sub on_start
my ($self) = @_;
$self->{step} = $self->x_resource("%.step") || 1;
+ $self->{keepwin} = $self->x_resource_boolean("%.keepwin") || 0;
+ if ($self->{keepwin}) {
+ ($self->{x}, $self->{y}, $self->{cw}, $self->{dx}, $self->{dy}) = (
+ $self->XTranslateCoordinates($self->parent, $self->DefaultRootWindow, 0, 0),
+ $self->width(), $self->height());
+ }
foreach my $type (qw(font boldFont italicFont boldItalicFont)) {
$self->{$type} = $self->x_resource($type) || "undef";
@@ -203,11 +217,13 @@ sub fonts_change_size
push @newfonts, $newfont;
}
my $newres = join(",", @newfonts);
+ window_keep($term, 1);
font_apply_new($term, $newres, "font", $save);
handle_type($term, "boldFont", $delta, $newbasedelta, $newbasesize, $save);
handle_type($term, "italicFont", $delta, $newbasedelta, $newbasesize, $save);
handle_type($term, "boldItalicFont", $delta, $newbasedelta, $newbasesize, $save);
+ window_keep($term, 2);
}
if ($save > 1) {
@@ -221,12 +237,14 @@ sub fonts_reset
{
my ($term) = @_;
+ window_keep($term, 1);
foreach my $type (qw(font boldFont italicFont boldItalicFont)) {
my $initial = $term->{$type};
if ($initial ne "undef") {
font_apply_new($term, $initial, $type, 0);
}
}
+ window_keep($term, 2);
}
sub fonts_show
@@ -469,3 +487,35 @@ sub font_apply_new
close(XRDB_MERGE) || die "bad xrdb: $! $?";
}
}
+
+sub window_keep
+{
+ my ($term, $run) = @_;
+
+ if (!$term->{keepwin}) { return; }
+
+ my $atom = $term->XInternAtom('_NET_WM_STATE'); # Atoms[]/32
+ my ($type, $format, $octets) = $term->XGetWindowProperty($term->parent, $atom);
+ my %states = map { $_ => 1 } unpack 'l!*', $octets;
+ # 366 => _NET_WM_STATE_FOCUSED, 303 => _NET_WM_STATE_FULLSCREEN,
+ # 305 => _NET_WM_STATE_MAXIMIZED_VERT, 306 => _NET_WM_STATE_MAXIMIZED_HORZ
+ if (exists($states{303}) || (exists($states{305}) && exists($states{306}))) {
+ return;
+ }
+# print "---------- #" . $run . " sub window_keep ----------\n";
+
+ if ($run == 1) {
+ $atom = $term->XInternAtom('_NET_FRAME_EXTENTS'); # Cardinal[4]/32; WM MUST set _NET_FRAME_EXTENTS
+ ($type, $format, $octets) = $term->XGetWindowProperty($term->parent, $atom);
+ my (@extents) = unpack 'l!*', $octets; # left, right, top, bottom
+ my ($x, $y, $cw) = $term->XTranslateCoordinates($term->parent, $term->DefaultRootWindow, 0, 0);
+ ($term->{x}, $term->{y}, $term->{cw}, $term->{dx}, $term->{dy}) = (
+ $x - $extents[0], $y - $extents[2], $cw, $term->width(), $term->height());
+
+# print "\$x:" . $term->{x} . " \$y:" . $term->{y} . " \$cw:" . $term->{cw} . " \$dx:" . $term->{dx} . " \$dy:" . $term->{dy} . "\n";
+ } elsif ($run == 2) {
+ $term->XMoveResizeWindow($term->parent, $term->{x}, $term->{y}, $term->{dx}, $term->{dy});
+
+# print "\$x:" . $term->{x} . " \$y:" . $term->{y} . " \$cw:" . $term->{cw} . " \$dx:" . $term->{dx} . " \$dy:" . $term->{dy} . "\n";
+ }
+}
