Re: [gentoo-dev] Last rites: app-admin/fluentd

[Jaco Kroon]

Hi,

On 2024/01/09 13:42, Michał Górny wrote:
On Tue, 2024-01-09 at 12:54 +0200, Jaco Kroon wrote:
https://github.com/gentoo/gentoo/pull/34126 ??
Perhaps I'm missing something if you say it's non-trivial but we're
using that on 9 hosts currently.

Do tests pass for you?  https://bugs.gentoo.org/879181#c2 indicated that
they do not.

How critical is it that they do?

Even for the bump PR they do not, they fail with the below, and frankly 
my knowledge of ruby is outright scary.  The below to me indicates that 
the tests are designed specifically to run from a git checkout, there 
are two possible "fixes":

1.  patch the code to not require this.
2.  disable tests.

>>> Test phase: app-admin/fluentd-1.16.3
 * Running test phase for ruby31
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
/usr/bin/ruby31 -w -I"lib:test" -Eascii-8bit:ascii-8bit 
/usr/lib64/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb 
"test/command/test_binlog_reader.rb" "test/command/test_ca_generate.rb" 
"test/command/test_cap_ctl.rb" "test/command/test_cat.rb" 
"test/command/test_ctl.rb" "test/command/test_fluentd.rb" 
"test/command/test_plugin_config_formatter.rb" 
"test/command/test_plugin_generator.rb" 
"test/compat/test_calls_super.rb" "test/compat/test_parser.rb" 
"test/config/test_config_parser.rb" "test/config/test_configurable.rb" 
"test/config/test_configure_proxy.rb" "test/config/test_dsl.rb" 
"test/config/test_element.rb" "test/config/test_literal_parser.rb" 
"test/config/test_plugin_configuration.rb" "test/config/test_section.rb" 
"test/config/test_system_config.rb" "test/config/test_types.rb" 
"test/counter/test_client.rb" "test/counter/test_error.rb" 
"test/counter/test_mutex_hash.rb" "test/counter/test_server.rb" 
"test/counter/test_store.rb" "test/counter/test_validator.rb" 
"test/log/test_console_adapter.rb" "test/plugin/in_tail/test_fifo.rb" 
"test/plugin/in_tail/test_io_handler.rb" 
"test/plugin/in_tail/test_position_file.rb" 
"test/plugin/out_forward/test_ack_handler.rb" 
"test/plugin/out_forward/test_connection_manager.rb" 
"test/plugin/out_forward/test_handshake_protocol.rb" 
"test/plugin/out_forward/test_load_balancer.rb" 
"test/plugin/out_forward/test_socket_cache.rb" 
"test/plugin/test_bare_output.rb" "test/plugin/test_base.rb" 
"test/plugin/test_buf_file.rb" "test/plugin/test_buf_file_single.rb" 
"test/plugin/test_buf_memory.rb" "test/plugin/test_buffer.rb" 
"test/plugin/test_buffer_chunk.rb" 
"test/plugin/test_buffer_file_chunk.rb" 
"test/plugin/test_buffer_file_single_chunk.rb" 
"test/plugin/test_buffer_memory_chunk.rb" 
"test/plugin/test_compressable.rb" "test/plugin/test_file_util.rb" 
"test/plugin/test_filter.rb" "test/plugin/test_filter_grep.rb" 
"test/plugin/test_filter_parser.rb" 
"test/plugin/test_filter_record_transformer.rb" 
"test/plugin/test_filter_stdout.rb" "test/plugin/test_formatter_csv.rb" 
"test/plugin/test_formatter_hash.rb" 
"test/plugin/test_formatter_json.rb" 
"test/plugin/test_formatter_ltsv.rb" 
"test/plugin/test_formatter_msgpack.rb" 
"test/plugin/test_formatter_out_file.rb" 
"test/plugin/test_formatter_single_value.rb" 
"test/plugin/test_formatter_tsv.rb" "test/plugin/test_in_debug_agent.rb" 
"test/plugin/test_in_exec.rb" "test/plugin/test_in_forward.rb" 
"test/plugin/test_in_gc_stat.rb" "test/plugin/test_in_http.rb" 
"test/plugin/test_in_monitor_agent.rb" 
"test/plugin/test_in_object_space.rb" "test/plugin/test_in_sample.rb" 
"test/plugin/test_in_syslog.rb" "test/plugin/test_in_tail.rb" 
"test/plugin/test_in_tcp.rb" "test/plugin/test_in_udp.rb" 
"test/plugin/test_in_unix.rb" "test/plugin/test_input.rb" 
"test/plugin/test_metadata.rb" "test/plugin/test_metrics.rb" 
"test/plugin/test_metrics_local.rb" "test/plugin/test_multi_output.rb" 
"test/plugin/test_out_copy.rb" "test/plugin/test_out_exec.rb" 
"test/plugin/test_out_exec_filter.rb" "test/plugin/test_out_file.rb" 
"test/plugin/test_out_forward.rb" "test/plugin/test_out_http.rb" 
"test/plugin/test_out_null.rb" "test/plugin/test_out_relabel.rb" 
"test/plugin/test_out_roundrobin.rb" 
"test/plugin/test_out_secondary_file.rb" 
"test/plugin/test_out_stdout.rb" "test/plugin/test_out_stream.rb" 
"test/plugin/test_output.rb" "test/plugin/test_output_as_buffered.rb" 
"test/plugin/test_output_as_buffered_backup.rb" 
"test/plugin/test_output_as_buffered_compress.rb" 
"test/plugin/test_output_as_buffered_overflow.rb" 
"test/plugin/test_output_as_buffered_retries.rb" 
"test/plugin/test_output_as_buffered_secondary.rb" 
"test/plugin/test_output_as_standard.rb" "test/plugin/test_owned_by.rb" 
"test/plugin/test_parser.rb" "test/plugin/test_parser_apache.rb" 
"test/plugin/test_parser_apache2.rb" 
"test/plugin/test_parser_apache_error.rb" 
"test/plugin/test_parser_csv.rb" "test/plugin/test_parser_json.rb" 
"test/plugin/test_parser_labeled_tsv.rb" 
"test/plugin/test_parser_multiline.rb" 
"test/plugin/test_parser_nginx.rb" "test/plugin/test_parser_none.rb" 
"test/plugin/test_parser_regexp.rb" "test/plugin/test_parser_syslog.rb" 
"test/plugin/test_parser_tsv.rb" "test/plugin/test_sd_file.rb" 
"test/plugin/test_sd_srv.rb" "test/plugin/test_storage.rb" 
"test/plugin/test_storage_local.rb" "test/plugin/test_string_util.rb" 
"test/plugin_helper/http_server/test_app.rb" 
"test/plugin_helper/http_server/test_route.rb" 
"test/plugin_helper/service_discovery/test_manager.rb" 
"test/plugin_helper/service_discovery/test_round_robin_balancer.rb" 
"test/plugin_helper/test_cert_option.rb" 
"test/plugin_helper/test_child_process.rb" 
"test/plugin_helper/test_compat_parameters.rb" 
"test/plugin_helper/test_event_emitter.rb" 
"test/plugin_helper/test_event_loop.rb" 
"test/plugin_helper/test_extract.rb" 
"test/plugin_helper/test_formatter.rb" 
"test/plugin_helper/test_http_server_helper.rb" 
"test/plugin_helper/test_inject.rb" "test/plugin_helper/test_metrics.rb" 
"test/plugin_helper/test_parser.rb" 
"test/plugin_helper/test_record_accessor.rb" 
"test/plugin_helper/test_retry_state.rb" 
"test/plugin_helper/test_server.rb" 
"test/plugin_helper/test_service_discovery.rb" 
"test/plugin_helper/test_socket.rb" "test/plugin_helper/test_storage.rb" 
"test/plugin_helper/test_thread.rb" "test/plugin_helper/test_timer.rb" 
"test/test_capability.rb" "test/test_clock.rb" "test/test_config.rb" 
"test/test_configdsl.rb" "test/test_daemonizer.rb" "test/test_engine.rb" 
"test/test_event.rb" "test/test_event_router.rb" 
"test/test_file_wrapper.rb" "test/test_filter.rb" 
"test/test_fluent_log_event_router.rb" "test/test_formatter.rb" 
"test/test_input.rb" "test/test_log.rb" "test/test_match.rb" 
"test/test_mixin.rb" "test/test_msgpack_factory.rb" 
"test/test_oj_options.rb" "test/test_output.rb" "test/test_plugin.rb" 
"test/test_plugin_classes.rb" "test/test_plugin_helper.rb" 
"test/test_plugin_id.rb" "test/test_process.rb" 
"test/test_root_agent.rb" "test/test_static_config_analysis.rb" 
"test/test_supervisor.rb" "test/test_test_drivers.rb" 
"test/test_time_formatter.rb" "test/test_time_parser.rb" 
"test/test_tls.rb" "test/test_unique_id.rb" "test/test_variable_store.rb"
<internal:/usr/lib64/ruby/site_ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in 
`require': cannot load such file -- rr (LoadError)
    from 
<internal:/usr/lib64/ruby/site_ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in 
`require'
    from 
/var/tmp/portage/app-admin/fluentd-1.16.3/work/ruby31/fluentd-1.16.3/test/helper.rb:38:in 
`<top (required)>'
    from 
/var/tmp/portage/app-admin/fluentd-1.16.3/work/ruby31/fluentd-1.16.3/test/command/test_binlog_reader.rb:1:in 
`require_relative'
    from 
/var/tmp/portage/app-admin/fluentd-1.16.3/work/ruby31/fluentd-1.16.3/test/command/test_binlog_reader.rb:1:in 
`<top (required)>'
    from 
<internal:/usr/lib64/ruby/site_ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in 
`require'
    from 
<internal:/usr/lib64/ruby/site_ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in 
`require'
    from 
/usr/lib64/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:21:in 
`block in <main>'
    from 
/usr/lib64/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:6:in 
`select'
    from 
/usr/lib64/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb:6:in 
`<main>'
rake aborted!
Command failed with status (1): [ruby -w -I"lib:test" 
-Eascii-8bit:ascii-8bit 
/usr/lib64/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb 
"test/command/test_binlog_reader.rb" "test/command/test_ca_generate.rb" 
"test/command/test_cap_ctl.rb" "test/command/test_cat.rb" 
"test/command/test_ctl.rb" "test/command/test_fluentd.rb" 
"test/command/test_plugin_config_formatter.rb" 
"test/command/test_plugin_generator.rb" 
"test/compat/test_calls_super.rb" "test/compat/test_parser.rb" 
"test/config/test_config_parser.rb" "test/config/test_configurable.rb" 
"test/config/test_configure_proxy.rb" "test/config/test_dsl.rb" 
"test/config/test_element.rb" "test/config/test_literal_parser.rb" 
"test/config/test_plugin_configuration.rb" "test/config/test_section.rb" 
"test/config/test_system_config.rb" "test/config/test_types.rb" 
"test/counter/test_client.rb" "test/counter/test_error.rb" 
"test/counter/test_mutex_hash.rb" "test/counter/test_server.rb" 
"test/counter/test_store.rb" "test/counter/test_validator.rb" 
"test/log/test_console_adapter.rb" "test/plugin/in_tail/test_fifo.rb" 
"test/plugin/in_tail/test_io_handler.rb" 
"test/plugin/in_tail/test_position_file.rb" 
"test/plugin/out_forward/test_ack_handler.rb" 
"test/plugin/out_forward/test_connection_manager.rb" 
"test/plugin/out_forward/test_handshake_protocol.rb" 
"test/plugin/out_forward/test_load_balancer.rb" 
"test/plugin/out_forward/test_socket_cache.rb" 
"test/plugin/test_bare_output.rb" "test/plugin/test_base.rb" 
"test/plugin/test_buf_file.rb" "test/plugin/test_buf_file_single.rb" 
"test/plugin/test_buf_memory.rb" "test/plugin/test_buffer.rb" 
"test/plugin/test_buffer_chunk.rb" 
"test/plugin/test_buffer_file_chunk.rb" 
"test/plugin/test_buffer_file_single_chunk.rb" 
"test/plugin/test_buffer_memory_chunk.rb" 
"test/plugin/test_compressable.rb" "test/plugin/test_file_util.rb" 
"test/plugin/test_filter.rb" "test/plugin/test_filter_grep.rb" 
"test/plugin/test_filter_parser.rb" 
"test/plugin/test_filter_record_transformer.rb" 
"test/plugin/test_filter_stdout.rb" "test/plugin/test_formatter_csv.rb" 
"test/plugin/test_formatter_hash.rb" 
"test/plugin/test_formatter_json.rb" 
"test/plugin/test_formatter_ltsv.rb" 
"test/plugin/test_formatter_msgpack.rb" 
"test/plugin/test_formatter_out_file.rb" 
"test/plugin/test_formatter_single_value.rb" 
"test/plugin/test_formatter_tsv.rb" "test/plugin/test_in_debug_agent.rb" 
"test/plugin/test_in_exec.rb" "test/plugin/test_in_forward.rb" 
"test/plugin/test_in_gc_stat.rb" "test/plugin/test_in_http.rb" 
"test/plugin/test_in_monitor_agent.rb" 
"test/plugin/test_in_object_space.rb" "test/plugin/test_in_sample.rb" 
"test/plugin/test_in_syslog.rb" "test/plugin/test_in_tail.rb" 
"test/plugin/test_in_tcp.rb" "test/plugin/test_in_udp.rb" 
"test/plugin/test_in_unix.rb" "test/plugin/test_input.rb" 
"test/plugin/test_metadata.rb" "test/plugin/test_metrics.rb" 
"test/plugin/test_metrics_local.rb" "test/plugin/test_multi_output.rb" 
"test/plugin/test_out_copy.rb" "test/plugin/test_out_exec.rb" 
"test/plugin/test_out_exec_filter.rb" "test/plugin/test_out_file.rb" 
"test/plugin/test_out_forward.rb" "test/plugin/test_out_http.rb" 
"test/plugin/test_out_null.rb" "test/plugin/test_out_relabel.rb" 
"test/plugin/test_out_roundrobin.rb" 
"test/plugin/test_out_secondary_file.rb" 
"test/plugin/test_out_stdout.rb" "test/plugin/test_out_stream.rb" 
"test/plugin/test_output.rb" "test/plugin/test_output_as_buffered.rb" 
"test/plugin/test_output_as_buffered_backup.rb" 
"test/plugin/test_output_as_buffered_compress.rb" 
"test/plugin/test_output_as_buffered_overflow.rb" 
"test/plugin/test_output_as_buffered_retries.rb" 
"test/plugin/test_output_as_buffered_secondary.rb" 
"test/plugin/test_output_as_standard.rb" "test/plugin/test_owned_by.rb" 
"test/plugin/test_parser.rb" "test/plugin/test_parser_apache.rb" 
"test/plugin/test_parser_apache2.rb" 
"test/plugin/test_parser_apache_error.rb" 
"test/plugin/test_parser_csv.rb" "test/plugin/test_parser_json.rb" 
"test/plugin/test_parser_labeled_tsv.rb" 
"test/plugin/test_parser_multiline.rb" 
"test/plugin/test_parser_nginx.rb" "test/plugin/test_parser_none.rb" 
"test/plugin/test_parser_regexp.rb" "test/plugin/test_parser_syslog.rb" 
"test/plugin/test_parser_tsv.rb" "test/plugin/test_sd_file.rb" 
"test/plugin/test_sd_srv.rb" "test/plugin/test_storage.rb" 
"test/plugin/test_storage_local.rb" "test/plugin/test_string_util.rb" 
"test/plugin_helper/http_server/test_app.rb" 
"test/plugin_helper/http_server/test_route.rb" 
"test/plugin_helper/service_discovery/test_manager.rb" 
"test/plugin_helper/service_discovery/test_round_robin_balancer.rb" 
"test/plugin_helper/test_cert_option.rb" 
"test/plugin_helper/test_child_process.rb" 
"test/plugin_helper/test_compat_parameters.rb" 
"test/plugin_helper/test_event_emitter.rb" 
"test/plugin_helper/test_event_loop.rb" 
"test/plugin_helper/test_extract.rb" 
"test/plugin_helper/test_formatter.rb" 
"test/plugin_helper/test_http_server_helper.rb" 
"test/plugin_helper/test_inject.rb" "test/plugin_helper/test_metrics.rb" 
"test/plugin_helper/test_parser.rb" 
"test/plugin_helper/test_record_accessor.rb" 
"test/plugin_helper/test_retry_state.rb" 
"test/plugin_helper/test_server.rb" 
"test/plugin_helper/test_service_discovery.rb" 
"test/plugin_helper/test_socket.rb" "test/plugin_helper/test_storage.rb" 
"test/plugin_helper/test_thread.rb" "test/plugin_helper/test_timer.rb" 
"test/test_capability.rb" "test/test_clock.rb" "test/test_config.rb" 
"test/test_configdsl.rb" "test/test_daemonizer.rb" "test/test_engine.rb" 
"test/test_event.rb" "test/test_event_router.rb" 
"test/test_file_wrapper.rb" "test/test_filter.rb" 
"test/test_fluent_log_event_router.rb" "test/test_formatter.rb" 
"test/test_input.rb" "test/test_log.rb" "test/test_match.rb" 
"test/test_mixin.rb" "test/test_msgpack_factory.rb" 
"test/test_oj_options.rb" "test/test_output.rb" "test/test_plugin.rb" 
"test/test_plugin_classes.rb" "test/test_plugin_helper.rb" 
"test/test_plugin_id.rb" "test/test_process.rb" 
"test/test_root_agent.rb" "test/test_static_config_analysis.rb" 
"test/test_supervisor.rb" "test/test_test_drivers.rb" 
"test/test_time_formatter.rb" "test/test_time_parser.rb" 
"test/test_tls.rb" "test/test_unique_id.rb" "test/test_variable_store.rb" ]

Tasks: TOP => test => base_test
(See full trace by running task with --trace)